DESCRIPTION

Have a window title in RefSpecWizard

Technically that dialog is about refspecs, but I've choosen "Configure
push" and "Configure fetch" as window title, because that probably fits
the workflow and mental model of the average user better.

Change-Id: Ib758f703131bc3518d3fde7114807af22094f9f8
Signed-off-by: Jack Yu xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-11-23 07:22:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5356/

-------------------------------------
author: Brenden Conley
date: 2013-11-23 07:35:56.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5356/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2013-11-23 15:18:40.000000000

Patch Set 1:

(3 comments)

See inline comment,s otherwise looks good.

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/RefSpecWizard.java -> Please add the year here, like so:

Copyright (C) 2010, 2013 Willow Cantrell xxx@xxx.xxx and others.

See also this guide: https://wiki.eclipse.org/EGit/Contributor_Guide#Copyright

Line:49, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/RefSpecWizard.java -> We don't use braces ({}) for such simple one-line statements, please remove them.

Line:591, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Titles should be in "title capitalization", so these should be "Configure Push" and "Configure Fetch".

-------------------------------------
