DESCRIPTION

disable Delete button when current branch is selected in Checkout dialog

Change-Id: If4e19f1589e3a8044d259e0e7c7d3ba27825a06a
Signed-off-by: Clay Cameron xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-10-30 14:38:19.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5166/

-------------------------------------
author: Brenden Conley
date: 2013-10-30 14:52:03.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/egit/job/egit.gerrit/5166/ : SUCCESS

-------------------------------------
author: Carlie Harper
date: 2013-10-31 09:58:01.000000000

Patch Set 1: Code-Review-1

(1 comment)

Looks good, only a small nit

Line:7, /COMMIT_MSG -> Our header lines usually start with upper case.

-------------------------------------
author: Carlie Harper
date: 2013-10-31 10:15:08.000000000

Patch Set 1:

(1 comment)

Now I found an issue...

Line:124, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CheckoutDialog.java -> This breaks disabling the button in case of multi selection. In this case refName is null.

But indeed this is not very clear. Maybe we better put two different statements into the if/else block above:
 if {
 ...			
  okButton.setEnabled(false);
  } else {
 ... 
  okButton.setEnabled(!isCurrentBranch(refName));
 }

-------------------------------------
author: Clay Cameron
date: 2013-10-31 11:14:49.000000000

Patch Set 1:

(2 comments)

Line:124, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CheckoutDialog.java -> Done

Line:7, /COMMIT_MSG -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2013-10-31 11:44:40.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
