DESCRIPTION

[repoView] Show checkout confirmation

Ask for confirmation if double-clicking on branch or tag in Git
Repositories

Bug: 417971
Change-Id: I3e581e62cef01ed51d8ac3cae72aa287900d5e72
Also-by: Danika Greer xxx@xxx.xxx
Also-by: Sebastian Poetzsch xxx@xxx.xxx
Signed-off-by: Yurem Baxter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-10-29 23:06:13.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5158/

-------------------------------------
author: Brenden Conley
date: 2013-10-29 23:20:09.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/5158/ : UNSTABLE

-------------------------------------
author: Danika Greer
date: 2013-10-30 08:28:56.000000000

Patch Set 1: Code-Review-1

The test failure is caused by this change, could you adapt the test so that it clicks on OK in the dialog?

-------------------------------------
author: Douglas Trujillo
date: 2013-10-30 09:35:37.000000000

Patch Set 1: Code-Review-1

(3 comments)

Line:463, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesView.java -> style nit: we don't use braces around single line blocks

Line:1075, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> typo: s/Configurmation/Confirmation/

Line:1076, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> in other similar dialogs we say "Don't show this confirmation dialog again" so we could use the same text here to gain a bit more consistency

-------------------------------------
author: Yurem Baxter
date: 2013-10-30 14:52:42.000000000

Patch Set 1:

(3 comments)

Line:463, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesView.java -> Done

Line:1075, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> It was pretty late last day :)
Done

Line:1076, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> Done

-------------------------------------
author: Gerrit Johnathan Pham
date: 2013-10-30 17:59:07.000000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
