DESCRIPTION

Add dialog settings to project import dialog

Improves user experience of the import projects wizard dialog by
providing dialog settings for remembering bounds on subsequent
invocation.

Bug: 419631
Change-Id: Ic3564d54d5af18da90dcd0e7fc2459695b0fc7e3
Signed-off-by: Kailee Jordan xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-10-18 18:33:26.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/5037/

-------------------------------------
author: Brenden Conley
date: 2013-10-18 18:49:05.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/5037/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2013-10-18 21:55:09.000000000

Patch Set 1: Code-Review-1

(5 comments)

Line:32, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java -> remove this unrelated formatting change

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java -> I think instead of creating a new class ImportProjectsWizardDialog this should be inlined as an anonymous class since it's only used in this single place and just overrides a single method:

 		WizardDialog dlg = new WizardDialog(getShell(event),
				new GitCreateProjectViaWizardWizard(node.getRepository(), path)) {
xxx@xxx.xxx
			protected IDialogSettings getDialogBoundsSettings() {
				return Activator.getDefault().getDialogSettings();
			}
		};

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsWizardDialog.java -> missing license header

Line:11, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsWizardDialog.java -> style nit: remove unnecessary blank lines

Line:13, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsWizardDialog.java -> we don't use author tags

-------------------------------------
author: Kailee Jordan
date: 2013-10-19 16:43:31.000000000

Patch Set 1:

(4 comments)

Removed new class again, thanks for the review.

Line:32, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java -> Done, that was an accidental change.

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsCommand.java -> Makes sense. I thought I would provide a new class (there already are a few in other places) in case there would be desire to provide yet more customization.

Line:11, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsWizardDialog.java -> Done

Line:13, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/tree/command/ImportProjectsWizardDialog.java -> Done

-------------------------------------
