DESCRIPTION

Validate new remote's name in NewRemoteDialog

Bug: 413137
Change-Id: I717d81b08e89efc49e487a4eb2b600abe0979ffe
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2013-09-29 20:58:05.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-09-29 21:12:18.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4990/

-------------------------------------
author: Brenden Conley
date: 2013-09-29 21:27:24.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/4990/ : UNSTABLE

-------------------------------------
author: Jack Yu
date: 2013-09-30 07:51:49.000000000

Patch Set 2: Code-Review+1

(2 comments)

Line:110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> I would also trim() the input here to avoid one more source of errors.

Line:128, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> If the text is trimmed above, it would have to be trimmed here also (or better, that one line to be extracted into a method).

-------------------------------------
author: Carlie Harper
date: 2013-10-01 07:32:15.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:117, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> this can be an else if

-------------------------------------
author: Douglas Trujillo
date: 2013-10-01 11:01:18.000000000

Patch Set 2:

(3 comments)

Line:110, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> Done

Line:117, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> Done

Line:128, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/NewRemoteDialog.java -> Done

-------------------------------------
