DESCRIPTION

[RFC] Add a view for interactive rebase

...

Change-Id: I6df48dcc31a803d362860b2a2287f72036ea607c
Signed-off-by: Alondra Arellano xxx@xxx.xxx


COMMENTS

author: Alondra Arellano
date: 2013-09-27 09:31:03.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2013-09-27 09:31:08.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4956/

-------------------------------------
author: Brenden Conley
date: 2013-09-27 09:31:59.000000000

Patch Set 4: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4956/ : FAILURE

-------------------------------------
author: Carlie Harper
date: 2013-09-27 14:18:26.000000000

Patch Set 4: Code-Review-1

(4 comments)

Move Up and Move Down does not work well
- It moves to the wrong direction
- in the file, the line is moved before the # Created by… line

Edit brings up a Conflict Dialog

Squash and fixup should not be possible in the first row

When a rebase was finished and i start a new one, I get an exception:
Caused by: java.lang.IllegalStateException: Need an underlying widget to be able to set the input.(Has the widget been disposed?)
	at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1681)
	at org.eclipse.egit.ui.internal.rebase.RebaseInteractiveView$8.run(RebaseInteractiveView.java:539)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)

Line:1845, org.eclipse.egit.ui/plugin.xml -> Please add the value to the plugin.properties

Line:183, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveStepActionToolBarProvider.java -> Maybe we add undo/redo in a subsequent change.

Line:423, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> Maybe we postpone redo/undo to a subsequent change

Line:436, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseInteractiveView.java -> We should find a header for the first column. What about "Status"?

-------------------------------------
