DESCRIPTION

[RFC] Add rebase interactive handler


Change-Id: I9e717d01047b7c97be8f4bd2059f2e165560180d
Signed-off-by: Alondra Arellano xxx@xxx.xxx

COMMENTS

author: Alondra Arellano
date: 2013-09-26 17:57:34.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-09-26 17:58:35.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4950/

-------------------------------------
author: Brenden Conley
date: 2013-09-26 17:59:57.000000000

Patch Set 5: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4950/ : FAILURE

-------------------------------------
author: Carlie Harper
date: 2013-09-27 07:41:19.000000000

Patch Set 5: Code-Review-1

(3 comments)

Line:125, org.eclipse.egit.core/src/org/eclipse/egit/core/op/RebaseOperation.java -> There is a lot of duplication in the different constructors.

You could use a private constructor called by the others:

....
		this(repository, operation, null, handler);
	}

	private RebaseOperation(Repository repository, Operation operation,
			Ref ref, InteractiveHandler handler) {
		this.repository = repository;
		this.operation = operation;
		this.ref = ref;
		this.handler = handler;
	}

Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbortRebaseCommand.java -> Why does the abort operation need the RebaseInteracitveHandler.INSTANCE?

Line:33, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/RebaseInteractiveCurrentHandler.java -> Do you want to do this in this change?

-------------------------------------
author: Alondra Arellano
date: 2013-09-27 10:52:13.000000000

Patch Set 5:

(3 comments)

Line:125, org.eclipse.egit.core/src/org/eclipse/egit/core/op/RebaseOperation.java -> Done

Line:36, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbortRebaseCommand.java -> Done

Line:33, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/RebaseInteractiveCurrentHandler.java -> Done

-------------------------------------
