DESCRIPTION

Refactor rebase commands

Joined duplicate code from RebaseHelper with
AbstractRebaseCommandHandler. Subclasses of AbstractRebaseCommandHandler
have to implement createRebaseOperation(...) which provides the rebase
operation to be called.

Change-Id: Ia463643b228ea3ab4f7ac6e3f92d785bfff30c6d
Signed-off-by: Alondra Arellano xxx@xxx.xxx


COMMENTS

author: Alondra Arellano
date: 2013-09-26 13:50:54.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2013-09-26 13:51:00.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4930/

-------------------------------------
author: Brenden Conley
date: 2013-09-26 14:05:50.000000000

Patch Set 6: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/4930/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2013-09-26 14:48:13.000000000

Patch Set 6: Code-Review-1

(3 comments)

in order to have consistent naming we could add another change on top of this one to rename all subclasses of AbstractRebaseCommandHandler :

s/xxxCommand/xxxCommandHandler/

Line:157, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> this is hardly understandable, maybe better:

"Factory method delegating creation of RebaseOperation to concrete subclasses."

Line:594, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseResultDialog.java -> remove this unrelated change

Line:96, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/RebaseCurrentRefCommand.java -> style nit: replace tab after "selection," by a space

-------------------------------------
author: Douglas Trujillo
date: 2013-09-26 15:04:00.000000000

Patch Set 6:

(1 comment)

Line:132, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> extract the repository here before calling createRepositoryOperation and change the signature of createRepositoryOperation to accept a Repository then you don't need getRepository() and extractRepository() and also the next change on top of this one doesn't need to subclass the concrete handlers anymore.

-------------------------------------
author: Alondra Arellano
date: 2013-09-26 17:01:41.000000000

Patch Set 6:

(4 comments)

Line:132, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> Done

Line:157, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> Done

Line:594, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/rebase/RebaseResultDialog.java -> Done

Line:96, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/RebaseCurrentRefCommand.java -> Done

-------------------------------------
