DESCRIPTION

Refactor rebase commands

Change-Id: Ia463643b228ea3ab4f7ac6e3f92d785bfff30c6d
Signed-off-by: Alondra Arellano xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2013-09-23 12:57:12.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4909/

-------------------------------------
author: Brenden Conley
date: 2013-09-23 12:59:41.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4909/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-09-23 13:18:18.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4910/

-------------------------------------
author: Brenden Conley
date: 2013-09-23 13:34:09.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/4910/ : UNSTABLE

-------------------------------------
author: Douglas Trujillo
date: 2013-09-23 15:44:27.000000000

Patch Set 1: Code-Review-1

(7 comments)

Line:79, org.eclipse.egit.core/src/org/eclipse/egit/core/op/RebaseOperation.java -> where did this come from ? you claim this is a refactoring

Line:87, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> here we should also show the exception which is the root cause of the problem -> use multistatus as this was done in RebaseHelper

Line:125, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> this is rather createRebaseOperation than an innocent getter

Line:133, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> I think we don't need this method, just make the member operation visible to the subclasses by declaring it protected

Line:154, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/AbstractRebaseCommandHandler.java -> unrelated change

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/commands/shared/RebaseCurrentRefCommandHandler.java -> if you rename this class you should also rename the other subclasses of AbstractRebaseCommandHandler

Line:69, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/RebaseCurrentHandler.java -> according to javadoc of AbstractHandler this method must return null

-------------------------------------
