DESCRIPTION

Ensure that RepositoryPropertyPage fires ConfigChangedEvents

RepositoryPropertyPage did not fire ConfigChangedEvents when a
configuration parameter was modified using the property page. This led
to missed refreshes in the EGit UI.

Change-Id: I2d5113af12512d9f429a57189c39b137c9b7c94f
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2013-09-20 12:12:30.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/195/

-------------------------------------
author: Brenden Conley
date: 2013-09-20 12:15:44.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/195/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-09-20 13:02:23.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit-stable.gerrit/199/

-------------------------------------
author: Brenden Conley
date: 2013-09-20 13:17:43.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit-stable.gerrit/199/ : UNSTABLE

-------------------------------------
author: Danika Greer
date: 2013-09-24 20:55:13.000000000

Patch Set 1:

(1 comment)

See inline comment, otherwise looks good.

Line:58, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertyPage.java -> I don't get this else, isn't config already set to this before the if?

-------------------------------------
author: Danika Greer
date: 2013-09-24 20:57:37.000000000

Patch Set 1:

(1 comment)

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertyPage.java -> Repository also has fireEvent, should we rather use that?

-------------------------------------
author: Douglas Trujillo
date: 2013-09-24 22:47:10.000000000

Patch Set 1:

(2 comments)

Line:54, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertyPage.java -> Done

Line:58, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertyPage.java -> *sigh* you are right

-------------------------------------
