DESCRIPTION

[repoView] Show Gerrit icon for repositories configured for Gerrit

Change-Id: I1640c20dbe16699fad0eae2bc304e63603163149
Signed-off-by: Douglas Trujillo xxx@xxx.xxx

COMMENTS

author: Douglas Trujillo
date: 2013-09-09 08:19:16.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-09-09 08:19:21.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4866/

-------------------------------------
author: Brenden Conley
date: 2013-09-09 08:22:08.000000000

Patch Set 2: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4866/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-09-09 09:12:29.000000000

Patch Set 2: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4868/

-------------------------------------
author: Brenden Conley
date: 2013-09-09 09:27:35.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/egit/job/egit.gerrit/4868/ : UNSTABLE

-------------------------------------
author: Danika Greer
date: 2013-09-15 19:39:25.000000000

Patch Set 2: Code-Review-2

(2 comments)

Nice idea! Works good, but see inline comment about dispose.

Line:70, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewLabelProvider.java -> The image must be disposed, either by adding a call in dispose or creating it like this (IMO preferred):

	private final Image gerritRepoImage = resourceManager
			.createImage(UIIcons.REPOSITORY_GERRIT);

Line:133, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewLabelProvider.java -> Could we use the hasGerritConfiguration method directly here (by making it public)? I think that would be nicer than the magic string. But if you prefer it, it's ok by me.

-------------------------------------
author: Douglas Trujillo
date: 2013-09-17 14:10:09.000000000

Patch Set 2:

(2 comments)

Line:70, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewLabelProvider.java -> Done

Line:133, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoriesViewLabelProvider.java -> Done

-------------------------------------
