DESCRIPTION

Refactoring and cleanup in GitModel

The inheritance tree of GitModelObject were cleaned up. Common code were
extracted into new GitModelObjectContainer.

New GitModelObjectContainer is also an extension point for adding
support to displaying git cache/index status and working directory
status in ChangeSet.

Change-Id: I5e723828ebcafa34c838a81e1a9fc71749bd07d8
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2010-09-10 12:46:20.000000000

Uploaded patch set 2.

-------------------------------------
author: Carlie Harper
date: 2010-09-13 12:40:03.000000000

Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)

Please have a look at the inline comments.

Line:53, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCommit.java -> Why was this line moved? I seems to belong to the parameter "direction".

Line:168, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelObjectContainer.java -> This TODO can be removed with this commit.

Line:182, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelObjectContainer.java -> This TODO can be removed with this commit.

Line:9, /COMMIT_MSG -> ...was cleaned up...  ...was extracted

-------------------------------------
author: Leslie Stephenson
date: 2010-09-13 20:03:35.000000000

Patch Set 2: (4 inline comments)



Line:53, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelCommit.java -> Indeed, I was experimenting with direction parameter and because of that both elements were merge together.

Line:168, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelObjectContainer.java -> Done

Line:182, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/model/GitModelObjectContainer.java -> Done

Line:9, /COMMIT_MSG -> Done

-------------------------------------
