DESCRIPTION

[historyView] Disable Comment and Detail panes on multiple selection

This confuses users.

Bug: 324716
Change-Id: Ic784028b8c2cb2d9244d6a352196ca381e2022f7
Signed-off-by: Willow Cantrell xxx@xxx.xxx


COMMENTS

author: Douglas Trujillo
date: 2010-09-08 15:04:16.000000000

Patch Set 1: Looks good to me, but someone else must approve; IP review completed



-------------------------------------
author: Marley Hopkins
date: 2010-09-08 16:46:31.000000000

Patch Set 1: (2 inline comments)



Line:76, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitFileDiffViewer.java -> Instead of abusing a SashForm, wouldn't it be better to use a StackLayout for this usecase?

Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitFileDiffViewer.java -> Why TextViewer? new Text(sash, SWT.MULTI | SWT.READ_ONLY) should be sufficent

-------------------------------------
author: Willow Cantrell
date: 2010-09-09 07:18:11.000000000

Patch Set 1: (2 inline comments)



-------------------------------------
author: Willow Cantrell
date: 2010-09-09 07:18:11.000000000

Patch Set 1: (1 inline comment)



-------------------------------------
author: Willow Cantrell
date: 2010-09-09 07:18:10.000000000

MISMATCHED INLINE COMMENT
Line:76, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitFileDiffViewer.java -> Done

-------------------------------------
author: Willow Cantrell
date: 2010-09-09 07:18:10.000000000

MISMATCHED INLINE COMMENT
Line:78, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitFileDiffViewer.java -> Now it's StyledText, because we want to have the same font as in the message viewer.

-------------------------------------
