DESCRIPTION

Provide a reusable composite for selecting (and editing) a branch

* Allow to edit branches while fetching from Gerrit
* Switch CheckoutDialog to use the new composite

Change-Id: I282c748ffbc21fd4fc3fe2fa955c8dee4ffe3524
Signed-off-by: Clay Cameron xxx@xxx.xxx

COMMENTS

author: Clay Cameron
date: 2013-09-19 10:59:15.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-09-19 10:59:21.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4906/

-------------------------------------
author: Brenden Conley
date: 2013-09-19 11:02:12.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4906/ : FAILURE

-------------------------------------
author: Danika Greer
date: 2013-09-19 11:46:29.000000000

Patch Set 3:

(5 comments)

Line:139, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionAndEditDialog.java -> The checkout dialog button layout looks wrong because there is space at the right, where usually the buttons are right-aligned. The cause for this is that numColumns is incremented too many times.

createButton already increases the number of columns. I'd move this down to be called before new Button.

Line:145, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionAndEditDialog.java -> Also, move this down, it's the increase for the delete button.

Line:151, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionAndEditDialog.java -> Remove this.

Line:1647, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/uitext.properties -> This should be something like "&Edit Branches..."

Line:226, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/fetch/FetchGerritChangePage.java -> The above makes the buttons not be displayed, but the layout is wrong (buttons are not right-aligned).

How about providing protected methods like createRenameButton() and createDeleteButton, and createCancelButton() in BranchSelectionAndEditDialog and then using them here, and not call super.createButtonsForButtonBar?

-------------------------------------
author: Brenden Conley
date: 2013-09-20 09:26:05.000000000

Patch Set 3: -Verified

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4907/

-------------------------------------
author: Brenden Conley
date: 2013-09-20 09:28:41.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4907/ : FAILURE

-------------------------------------
