DESCRIPTION

[WIP] provide a reusable composite for selecting (and editing) a branch

Change-Id: I282c748ffbc21fd4fc3fe2fa955c8dee4ffe3524
Signed-off-by: Clay Cameron xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-08-19 09:02:49.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4813/

-------------------------------------
author: Brenden Conley
date: 2013-08-19 09:05:24.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4813/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-08-19 09:13:26.000000000

Patch Set 1: -Verified

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4804/

-------------------------------------
author: Brenden Conley
date: 2013-08-19 09:29:17.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4804/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2013-08-19 12:52:22.000000000

Patch Set 1: Code-Review-1

(5 comments)

File Comment: org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> This class would fit nicely in the "org.eclipse.egit.ui.internal.components" package.

Line:37, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> How about "BranchSelectionComponent"?

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> How about doing this in the constructor like in other SWT controls? Then the caller could not forget calling createContent() before accessing other things.

Line:91, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> checkPage could be added by the client, by exposing the button as a getter here, e.g.:

    Button getSelectButton() { ... }

and the client then does this:

    getSelectButton().addSelectionListener(...);

Line:48, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AdvancedBranchSelectionDialog.java -> "Advanced" is not very descriptive. If I read this correctly, it adds New, Rename and Delete buttons compared to the base class. How about "BranchSelectionAndEditDialog"? Should also be mentioned in the Javadoc.

-------------------------------------
author: Clay Cameron
date: 2013-08-20 08:47:31.000000000

Patch Set 1:

(8 comments)

Thanks for the feedback Robin!

File Comment: org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> Done

Line:37, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> Done

Line:62, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> Done

Line:91, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> It turned not to be an issue. For the FetchGerritChangePage checkPage can be called by a listener registered via addModifyListener on this class.

Line:149, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/branch/BranchSelectionBlock.java -> Done.

Line:48, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AdvancedBranchSelectionDialog.java -> Done

Line:81, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AdvancedBranchSelectionDialog.java -> Done.

Line:137, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AdvancedBranchSelectionDialog.java -> Fix typo. Done.

-------------------------------------
