DESCRIPTION

extract method for setting up button layout data in non-Dialog contexts

Change-Id: Ia5ebdfa28e27b6f5020e635e15172a29014d7df3
Signed-off-by: Clay Cameron xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-08-19 08:59:04.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/egit/job/egit.gerrit/4812/

-------------------------------------
author: Brenden Conley
date: 2013-08-19 08:59:04.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4803/

-------------------------------------
author: Brenden Conley
date: 2013-08-19 09:01:37.000000000

Patch Set 1: Verified-1

Build Failed 

https://hudson.eclipse.org/egit/job/egit.gerrit/4812/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-08-19 09:13:25.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4803/ : SUCCESS

-------------------------------------
author: Danika Greer
date: 2013-08-19 12:09:19.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:777, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> In DialogPage, the font that is used (initializeDialogUnits) is JFaceResources.getDialogFont(). Here, it's the button font. In LocationPage.createControl, Dialog.applyDialogFont is called at the end, which recursively changes the fonts of the controls.

That means the font which is set on the button when this method is called is not necessarily the same as the final font.

So, the question is if this method should use JFaceResources.getDialogFont() or if the font should be passed by the caller.

-------------------------------------
author: Clay Cameron
date: 2013-08-19 14:30:03.000000000

Patch Set 1:

(1 comment)

Line:777, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIUtils.java -> I like the former better. I will push a new patch in a sec.

-------------------------------------
