DESCRIPTION

Display details of push result

PushResultTable was enhanced to show the details of a push result.
Error messages and the information returned by the push operation
(e.g. the gerrit review URL) are shown in a separate text control.
The colors of the result status (green, red) were replaced by an icon.

Bug: 319974
Change-Id: I4000c80b8a3365dea3b4b6977f3e03271e634154
Signed-off-by: Marlie Beasley xxx@xxx.xxx

COMMENTS

author: Jaylon Avila
date: 2010-08-30 12:40:36.000000000

Patch Set 1: (6 inline comments)



Line:81, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Does this work on Windows? I'm wondering if it would be more appropriate to use Text.DELIMITER instead.

Line:93, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Since images are being used now, these fields should be removed as they are no longer of any use.

Line:172, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Use StringBuilder instead.

Line:188, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Use StringBuilder instead.

Line:190, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> If we trim trailing newlines, then wouldn't we get something like the following? It feels to me like there should be some additional division between the listing of the different repositories' results.

Repository XXX

Message
Repository XXX

Message

Line:192, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> I got some trailing whitespace here after a failed push because there were no additional messages. Do we need to trim again or is this intentional?

-------------------------------------
author: Marlie Beasley
date: 2010-08-30 14:41:38.000000000

Patch Set 1: (6 inline comments)



Line:81, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:93, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:172, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:188, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:190, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

Line:192, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultTable.java -> Done

-------------------------------------
