DESCRIPTION

Enable Git Team actions if editor is active

In addition, the RepositoryActionHandler.getSelection() methods
were changed to become more robust.

Bug: 323442
Bug: 322301
Bug: 306459 (remainder)
Change-Id: I7795e7760fa41f69b1c166a2e1c183616a90436c
Signed-off-by: Willow Cantrell xxx@xxx.xxx


COMMENTS

author: Jaylon Avila
date: 2010-08-24 17:55:50.000000000

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

There are other ways to retrieve information instead of downcasting.

Line:261, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Please don't downcast. I'm pretty sure this will result in a CCE in 4.x.

Use HandlerUtil's getActiveMenuSelection(ExecutionEvent) method instead.

Line:264, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Please don't downcast. I'm pretty sure this will result in a CCE in 4.x.

Use HandlerUtil's getCurrentSelection(ExecutionEvent) method instead.

Line:269, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> I think you can get by with calling HandlerUtil's getVariable(String, ExecutionEvent) method with ISources.ACTIVE_EDITOR_INPUT_NAME as the first parameter.

-------------------------------------
author: Willow Cantrell
date: 2010-08-25 07:03:44.000000000

Patch Set 1: (3 inline comments)



Line:261, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Done

Line:264, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Done

Line:269, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/actions/RepositoryActionHandler.java -> Done

-------------------------------------
