DESCRIPTION

Fire model synchornization in Repositories view

Fire Git Model Synchronization instead of Git Synchronization in
Repositories view.

Change-Id: Ia966df740f80b2799aecd45a2d37c9aae178e917
Signed-off-by: Leslie Stephenson xxx@xxx.xxx


COMMENTS

author: Leslie Stephenson
date: 2010-08-12 16:59:30.000000000

Uploaded patch set 2.

-------------------------------------
author: Malia Sampson
date: 2010-08-12 17:02:27.000000000

Patch Set 2: Looks good to me, approved; IP review completed

Looks good.

-------------------------------------
author: Malia Sampson
date: 2010-08-12 17:02:28.000000000

Change has been successfully merged into the git repository.

-------------------------------------
author: Marley Hopkins
date: 2010-08-12 17:11:56.000000000

Patch Set 2: (4 inline comments)



Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> I suggest to move this to the end of the class as this is the less interesting part of the class.

Line:81, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> Just use Platform.getWorkbench()....getActivePage(), This would help to get rid of all these warnings. Could even be part of UIUtils.

Line:96, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> I think this could be generified with <ResourceMapping>

Line:103, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> I think we could lay this out as constant. And why don't you push it into the isMappedToProvider? Seems we only want to check this for our provider.

-------------------------------------
author: Leslie Stephenson
date: 2010-08-12 17:17:27.000000000

Patch Set 2:

Could I amend this patch, or push a new one that will respect Anabel Bass's comments?

-------------------------------------
author: Malia Sampson
date: 2010-08-12 17:18:09.000000000

Patch Set 2:

New patch to push please ;)

-------------------------------------
author: Leslie Stephenson
date: 2010-08-12 17:36:22.000000000

Patch Set 2: (4 inline comments)

Please see:
http://egit.eclipse.org/r/1295

Line:39, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> Done

Line:81, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> Done

Line:96, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> Done

Line:103, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/GitModelSynchronize.java -> Done

-------------------------------------
