DESCRIPTION

Bug 407690 - Commit dialog should remember its last dialog size

Change-Id: I72d5bbcbd5d4a7b6c102d2f74151cf8ffa71c214
Signed-off-by: Alivia Ritter xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-05-09 21:44:53.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4500/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-09 21:55:26.000000000

Patch Set 1: Fails

Build Failed 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4500/ : FAILURE

-------------------------------------
author: Brenden Conley
date: 2013-05-10 05:59:25.000000000

Patch Set 1: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4503/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-10 06:14:49.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4503/ : SUCCESS

-------------------------------------
author: Juliet Cantu
date: 2013-05-12 11:21:05.000000000

Patch Set 1: (1 inline comment)



Line:599, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> What happens when you go from high to low resolution, e.g. a projector? Is the size clipped to the screen size?

-------------------------------------
author: Douglas Trujillo
date: 2013-05-12 22:07:50.000000000

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

please assert the contributor questions [1] as a comment on this review

[1] http://wiki.eclipse.org/EGit/Contributor_Guide#Legal_Paperwork

Line:596, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> style nit: we do not use braces around single line blocks

Line:7, /COMMIT_MSG -> style nit: we put reference to the bug into the footer, see example in http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
author: Kaeden Tapia
date: 2013-05-16 17:47:25.000000000

Patch Set 1: (3 inline comments)



Line:596, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Done

Line:599, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CommitDialog.java -> Yes. I tested by maximizing the dialog on a 1920x1200 monitor then reopening the dialog after changing my monitor to 640x480. The dialog was resized properly to fit.

Line:7, /COMMIT_MSG -> Done

-------------------------------------
