DESCRIPTION

Add presentation options to Staging View.

Bug: 407607
Change-Id: I6509f2ee0f63fccf0391418cc3d41223e71c41de
Signed-off-by: Madisyn Francis xxx@xxx.xxx

COMMENTS

author: Zara Gill
date: 2013-05-13 21:15:38.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2013-05-13 21:15:44.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4516/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-13 21:32:41.000000000

Patch Set 8: I would prefer that you didn't submit this

Build Unstable 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4516/ : UNSTABLE

-------------------------------------
author: Zara Gill
date: 2013-05-14 16:20:56.000000000

Patch Set 8:

UI test failure seems to be unrelated.

-------------------------------------
author: Douglas Trujillo
date: 2013-06-06 07:19:33.000000000

Patch Set 8: I would prefer that you didn't submit this

(8 inline comments)

some problems with the folder and packed folder representation:
- context menu on folders is missing which especially hampers multi-selection, when you add this also add some corresponding tests
- I can stage folders using drag&drop but I can't unstage them using drag&drop

I feel that switching the presentation mode for unstaged and staged pane should be coupled, so either provide a way to couple these modes or only have one set of toggle buttons to always switch the presentation mode of both panes

Line:184, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIPreferences.java -> we don't need xxx@xxx.xxx tags anymore after rebasing onto origin/master since we declared everything x-internal with 3.0

Line:116, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:120, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:134, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:137, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:329, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:339, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces here

Line:64, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> style nit: we don't use braces around single line blocks, more of these below

-------------------------------------
author: Zara Gill
date: 2013-06-27 20:20:58.000000000

Abandoned

Will submit a new change.

-------------------------------------
author: Zara Gill
date: 2013-06-28 13:57:16.000000000

Restored

-------------------------------------
