DESCRIPTION

Add presentation options to Staging View.  Follow up - Fix problem with
Tree presentation when no Eclipse project exists.

Bug: 407607
Change-Id: I6509f2ee0f63fccf0391418cc3d41223e71c41de
Signed-off-by: Madisyn Francis xxx@xxx.xxx

Add presentation options to Staging View.
Follow up - Fix problems with "Tree" presentation when there is no
Eclipse project.

Bug: 407607
Change-Id: I6509f2ee0f63fccf0391418cc3d41223e71c41de
Signed-off-by: Madisyn Francis xxx@xxx.xxx


COMMENTS

author: Zara Gill
date: 2013-05-10 01:47:49.000000000

Uploaded patch set 5.

-------------------------------------
author: Brenden Conley
date: 2013-05-10 01:58:58.000000000

Patch Set 5:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4502/ 

-------------------------------------
author: Brenden Conley
date: 2013-05-10 02:14:16.000000000

Patch Set 5: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4502/ : SUCCESS

-------------------------------------
author: Douglas Trujillo
date: 2013-05-10 22:46:55.000000000

Patch Set 5: I would prefer that you didn't submit this

(12 inline comments)

compressed mode:
- top level files (directly under repository root) aren't sorted properly

tree mode:
- wrong tree structure if changes are done in different 2nd level folders under the same top level folder

will attach screenshots of these problems to bug 407607

both in compressed and tree mode refreshing the view closes all folders, would be nice if opening state would be preserved across refresh

Line:72, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces around single line block

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces around single line block

Line:90, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> style nit: no braces around single line block, more of these below

Line:331, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> remove dead code

Line:329, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> style nit: no braces here

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> add your copyright header

Line:183, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIPreferences.java -> this change will probably not reach 3.0 since it requires a CQ (formal IP review by Eclipse IP team) so this should be xxx@xxx.xxx 3.1

Line:188, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIPreferences.java xxx@xxx.xxx 3.1

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> style nit: fix line endings, we always use unix line endings (\n) and UTF-8 character encoding

Line:45, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> how about folders which are located in the repository but not in the workspace ? The staging view is supporting non-workspace files and folders though platform will not auto-refresh them since it doesn't generate resource change events for non-workspace resources

Line:103, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> style nit: we don't use curly braces around single line blocks

Line:14, /COMMIT_MSG -> remove duplicated information in commit message

-------------------------------------
author: Douglas Trujillo
date: 2013-05-10 22:54:27.000000000

Patch Set 5: (1 inline comment)



Line:7, /COMMIT_MSG -> commit message header is too long see http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

-------------------------------------
author: Zara Gill
date: 2013-05-13 21:21:09.000000000

Patch Set 5: (10 inline comments)

Patch Set 8 addresses the inline comments.

Line:72, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:75, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:90, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:331, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewContentProvider.java -> Done

Line:329, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingView.java -> Done

Line:2, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingViewLabelProvider.java -> Done

Line:183, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIPreferences.java -> If I change this to @since 3.1, I get "Invalid @since 3.1 tag on STAGING_VIEW_PRESENTATION_UNSTAGED; expecting @since 3.0".  If I omit @since altogether, I get xxx@xxx.xxx tag on..."

Line:1, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> Done

Line:45, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> This shouldn't be a problem.  If the folder is not in the workspace, it will return null (similar to StagingEntry.getFile), which means it won't be decorated to indicate problems, etc.

Line:103, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/staging/StagingFolderEntry.java -> Done

-------------------------------------
author: Douglas Trujillo
date: 2013-06-05 15:05:04.000000000

Patch Set 5: (1 inline comment)



Line:183, org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIPreferences.java -> yeah, this doesn't yet work since we didn't update the version on the master branch yet, but we don't need xxx@xxx.xxx tags anymore after rebasing onto origin/master since we declared everything x-internal with 3.0

-------------------------------------
