DESCRIPTION

History View: Can't checkout remote tracking branch if it points to same
commit as the currently checked out branch

Bug: 385002
Change-Id: If07412a40cb28303af96c559fa1951efb81ec322


COMMENTS

author: Brenden Conley
date: 2013-04-21 23:04:43.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4435/ 

-------------------------------------
author: Clay Cameron
date: 2013-04-21 23:07:09.000000000

Patch Set 1: (1 inline comment)



Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CheckoutCommitHandler.java -> Ignore current branch.

-------------------------------------
author: Brenden Conley
date: 2013-04-21 23:19:01.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4435/ : SUCCESS

-------------------------------------
author: Akira Shields
date: 2013-04-22 11:22:16.000000000

Patch Set 1: Looks good to me, but someone else must approve

With this change it now works as expected :-)

-------------------------------------
author: Douglas Trujillo
date: 2013-04-23 08:43:33.000000000

Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)



Line:205, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommandHandler.java -> style nit: trailing whitespace

Line:218, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommandHandler.java -> style nit: no braces around single line blocks

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CheckoutCommitHandler.java -> nodes should be sorted by name

-------------------------------------
author: Douglas Trujillo
date: 2013-04-23 08:44:30.000000000

Patch Set 1: (1 inline comment)



Line:7, /COMMIT_MSG -> style nit: commit message header is too wide

-------------------------------------
author: Douglas Trujillo
date: 2013-04-23 08:45:57.000000000

Patch Set 1: (4 inline comments)



Line:205, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommandHandler.java -> Done

Line:218, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/AbstractHistoryCommandHandler.java -> Done

Line:38, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/command/CheckoutCommitHandler.java -> Done

Line:7, /COMMIT_MSG -> Done

-------------------------------------
