DESCRIPTION

Don't access disposed widget in StashCreateUI.showNoChangesToStash()

The method is called from the job and the original shell may not be
there anymore in case of showing this from the branch checkout dialog.

Bug: 389866
Change-Id: Idf7480a823fa84b684c00648a664ad3dac15cd70


COMMENTS

author: Brenden Conley
date: 2013-04-12 14:24:52.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4360/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-12 14:37:49.000000000

Patch Set 2: I would prefer that you didn't submit this

Build Unstable 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4360/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2013-04-12 16:00:59.000000000

Patch Set 2: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4364/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-12 16:04:01.000000000

Patch Set 2: Fails

Build Failed 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4364/ : FAILURE

-------------------------------------
author: Juliet Cantu
date: 2013-04-19 07:07:53.000000000

Patch Set 2: (1 inline comment)



Line:37, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/stash/StashCreateUI.java -> Storing the Shell seems like a bad idea, so maybe we should not do it.

-------------------------------------
author: Brenden Conley
date: 2013-04-19 14:29:24.000000000

Patch Set 2: No score

Build Started https://hudson.eclipse.org/sandbox/job/egit.gerrit/4429/ 

-------------------------------------
author: Brenden Conley
date: 2013-04-19 14:34:27.000000000

Patch Set 2: Fails

Build Failed 

https://hudson.eclipse.org/sandbox/job/egit.gerrit/4429/ : FAILURE

-------------------------------------
author: Danika Greer
date: 2013-04-19 14:41:46.000000000

Patch Set 2: (1 inline comment)



Line:37, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/stash/StashCreateUI.java -> How about passing it as an argument to createStash (for the InputDialog there)?

-------------------------------------
author: Danika Greer
date: 2013-04-19 14:52:17.000000000

Patch Set 2: (1 inline comment)



Line:37, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/stash/StashCreateUI.java -> See patch set 3.

-------------------------------------
