DESCRIPTION

Use newer trash icon on Eclipse Photon or newer

Copy the SVG and PNGs from the eclipse.platform.images git repository
and rename them from "trash.*" to "trash_flat.*".

Add a version check for the first version of the "org.eclipse.ui"
bundle that uses the new icon to decide which one to use in EGit.
EGit UI has a hard (non-optional) dependency on org.eclipse.ui
anyway, so this version check is acceptable.

Since we have a reference to the "trash can" icon in plugin.xml,
add a property tester for this bundle version check and use it in
plugin.xml to display one or the other icon in the context menu
entry for the "Garbage Collect" command in the context menu of the
repository view.

This ensures that EGit uses a trash icon visually identical to the
one used by the platform on which EGit runs, and thus the user is
presented with a consistent UI.

Bug: 525600
Change-Id: I98c869b0b84677bc67575edd7358a0a17954727c
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: Alayna Houston
date: 2017-10-19 19:06:41.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-10-19 19:06:48.000000000

Patch Set 2:

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10188/

-------------------------------------
author: Alayna Houston
date: 2017-10-19 19:08:17.000000000

Patch Set 2:

> I do believe inconsistent UIs.

*Chuckle*. A missing blank. Of course I meant "in consistent UIs".

-------------------------------------
author: Brenden Conley
date: 2017-10-19 19:29:42.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://ci.eclipse.org/egit/job/egit.gerrit/10188/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2017-10-19 19:51:11.000000000

Patch Set 2: -Code-Review

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10190/

-------------------------------------
author: Brenden Conley
date: 2017-10-19 20:13:34.000000000

Patch Set 2: Verified+1

Build Successful 

https://ci.eclipse.org/egit/job/egit.gerrit/10190/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-10-20 08:48:46.000000000

Patch Set 2: Code-Review+1

Looks good Thomas, thanks.

-------------------------------------
author: Douglas Trujillo
date: 2017-10-22 09:15:56.000000000

Patch Set 2: Code-Review+2

-------------------------------------
author: Douglas Trujillo
date: 2017-10-22 09:16:03.000000000

Change has been successfully merged by Douglas Trujillo

-------------------------------------
