DESCRIPTION

Add a test for cloning via HTTPS

Tests that cloning from an HTTPS server that has a certificate that
doesn't validate pops up the correct dialog, and that after trusting
the server all the same, the clone proceeds successfully.

Fixes some bugs in apparently never used parts of the
CustomPromptDialog that the EGitCredentialsProvider uses to get user
input.

Bug: 374703
JGit-Dependency: Ie1abada9a3d389ad4d8d52c2d5265d2764e3fb0e
Change-Id: I6e3dbf6bf7d0db1459d7baedf5b20be5c894aada
Signed-off-by: Alayna Houston xxx@xxx.xxx

COMMENTS

author: Alayna Houston
date: 2017-09-11 06:25:25.000000000

Uploaded patch set 4: Patch Set 3 was rebased.

-------------------------------------
author: Brenden Conley
date: 2017-09-11 06:49:31.000000000

Patch Set 4:

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10151/

-------------------------------------
author: Brenden Conley
date: 2017-09-11 06:55:59.000000000

Patch Set 4: Verified-1

Build Failed 

https://ci.eclipse.org/egit/job/egit.gerrit/10151/ : FAILURE

-------------------------------------
author: Douglas Trujillo
date: 2017-09-12 22:53:44.000000000

Patch Set 4:

(1 comment)

Line:109, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CustomPromptDialog.java -> could we use radio buttons instead of 2 checkboxes to show these two mutually exclusive options (skip verification for next operation | always skip verification for this repository) ?

-------------------------------------
author: Alayna Houston
date: 2017-09-13 06:21:17.000000000

Patch Set 4:

(1 comment)

Line:109, org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CustomPromptDialog.java -> Means the yes-no CredentialItem cannot be used anymore to ask a single yes-no question. I think if we wanted to use radio buttons or a combo box, we'd need a new kind of CredentialItem for a (single or multiple) choice from a list of values.

-------------------------------------
author: Brenden Conley
date: 2017-09-13 22:20:45.000000000

Patch Set 4: -Verified

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10153/

-------------------------------------
author: Brenden Conley
date: 2017-09-13 22:45:53.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://ci.eclipse.org/egit/job/egit.gerrit/10153/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2017-09-13 22:49:13.000000000

Patch Set 4: -Code-Review

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10154/

-------------------------------------
author: Brenden Conley
date: 2017-09-13 23:12:20.000000000

Patch Set 4: Code-Review-1

Build Unstable 

https://ci.eclipse.org/egit/job/egit.gerrit/10154/ : UNSTABLE

-------------------------------------
author: Alayna Houston
date: 2017-09-14 05:48:04.000000000

Patch Set 4: Code-Review-1

(1 comment)

Line:49, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardHttpsTest.java -> Guess this test has to wait here until that shell has closed, and the branches have been fetched.

-------------------------------------
author: Alayna Houston
date: 2017-09-14 06:01:13.000000000

MISMATCHED INLINE COMMENT
Line:49, org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/wizards/clone/GitCloneWizardHttpsTest.java -> Done

-------------------------------------
