DESCRIPTION

Replace findbugs by spotbugs

SpotBugs [1] is the spiritual successor of FindBugs, carrying on from
the point where it left off with support of its community.

Also add the spotbugs plugin to Oomph setup for developer installation.

[1] http://spotbugs.readthedocs.io/

See: https://git.eclipse.org/r/#/c/101312
Change-Id: Ifac801300c98a3f9b5663b6bf2ac7ee253d05292


COMMENTS

author: Douglas Trujillo
date: 2017-09-06 06:36:25.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-09-06 06:36:34.000000000

Patch Set 3: -Code-Review

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10148/

-------------------------------------
author: Brenden Conley
date: 2017-09-06 06:59:10.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://ci.eclipse.org/egit/job/egit.gerrit/10148/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2017-09-06 11:31:30.000000000

Patch Set 3: -Code-Review

Build Started https://ci.eclipse.org/egit/job/egit.gerrit/10149/

-------------------------------------
author: Brenden Conley
date: 2017-09-06 11:51:36.000000000

Patch Set 3: Verified+1

Build Successful 

https://ci.eclipse.org/egit/job/egit.gerrit/10149/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2017-09-06 12:11:27.000000000

Patch Set 3: Code-Review+1

Looks like we trade one bug for another.

From https://ci.eclipse.org/egit/job/egit.gerrit/10146 (findbugs):

  [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (findbugs) @ org.eclipse.egit.ui ---
  [INFO] Fork Value is true
     [java] The following errors occurred during analysis:
     [java]   Error constructing methodGen
     [java]     org.apache.bcel.classfile.ClassFormatException: Invalid method signature: !*
     [java]       At org.apache.bcel.classfile.Utility.typeOfSignature(Utility.java:1012)
     [java]       At org.apache.bcel.generic.Type.getType(Type.java:181)
     [java]       At org.apache.bcel.generic.MethodGen.<init>(MethodGen.java:258)
     [java]       At edu.umd.cs.findbugs.classfile.engine.bcel.MethodGenFactory.analyze(MethodGenFactory.java:90)
     [java]       At edu.umd.cs.findbugs.classfile.engine.bcel.MethodGenFactory.analyze(MethodGenFactory.java:41)
     [java]       At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:369)
     [java]       At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:322)
     [java]       At edu.umd.cs.findbugs.ba.ClassContext.getMethodAnalysis(ClassContext.java:1002)
     [java]       At edu.umd.cs.findbugs.ba.ClassContext.getMethodAnalysisNoException(ClassContext.java:976)
     [java]       At edu.umd.cs.findbugs.ba.ClassContext.getMethodGen(ClassContext.java:287)
     [java]       At edu.umd.cs.findbugs.detect.FindUseOfNonSerializableValue.analyzeMethod(FindUseOfNonSerializableValue.java:126)
     [java]       At edu.umd.cs.findbugs.detect.FindUseOfNonSerializableValue.visitClassContext(FindUseOfNonSerializableValue.java:94)
     [java]       At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
     [java]       At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1089)
     [java]       At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:283)
     [java]       At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
     [java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
     [java] Warnings generated: 34
  [INFO] Done FindBugs Analysis....

From https://ci.eclipse.org/egit/job/egit.gerrit/10149 (spotbugs):

  [INFO] --- spotbugs-maven-plugin:3.0.6:findbugs (findbugs) @ org.eclipse.egit.ui ---
  [INFO] Fork Value is true
     [java] The following classes needed for analysis were missing:
     [java]   run
     [java]   handleEvent
     [java]   widgetDisposed
     [java]   getProposal
     [java]   get
     [java]   propertyChange
     [java]   accept
     [java] Warnings generated: 34
     [java] Missing classes: 7
  [INFO] Done FindBugs Analysis....

Otherwise this appears to work. We'll need to watch out for that spotbugs issue #8 becoming resolved and then adapt this.

-------------------------------------
