DESCRIPTION

Bug 518611 - IWorkLeon OchoachPage.getViewStack doesn't support secondaryId

Change-Id: I328f63d23e77a23e3554eb92568d8afdf1ea2b6c
Signed-off-by: Camron Rhodes xxx@xxx.xxx

COMMENTS

author: Camron Rhodes
date: 2017-06-22 12:57:00.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-06-22 12:57:05.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12988/

-------------------------------------
author: Brenden Conley
date: 2017-06-22 13:27:13.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12988/ : UNSTABLE

-------------------------------------
author: Brenden Conley
date: 2017-06-22 13:42:21.000000000

Patch Set 1: -Code-Review

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12989/

-------------------------------------
author: Brenden Conley
date: 2017-06-22 14:11:36.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12989/ : SUCCESS

-------------------------------------
author: Jayvion Booth
date: 2017-06-23 07:40:30.000000000

Patch Set 1: Code-Review-1

(3 comments)

Thanks for contribution!
Looks good, but it would look even better if you would add a simple test for that, see org.eclipse.ui.tests.api.IWorkLeon OchoachPageTest.

See also comments in code.

Line:4515, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> can be null

Line:4516, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> please avoid multiple calls to same method which can return null

Line:4517, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java -> !isEmpty()

-------------------------------------
