DESCRIPTION

Bug 516993 - Confirmation dialog for delete error log entries should use
verbs

Change-Id: I94375ed0762632bc162e1224a0cb08f66fe1efa1
Signed-off-by: Sonny Fields xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2017-06-07 07:31:43.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-06-07 07:32:07.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12814/

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 07:49:36.000000000

Patch Set 2:

(1 comment)

Looks good, but can be improved. Good practice Shawn for you to learn how to update a code review.

Line:54, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/DeleteHandler.java -> Looks good but I think IDialogConstants.CANCEL_LABEL would be even nicer instead of IDialogConstants.NO_LABEL. Please update the Gerrit.

For this:

Use Ctrl+3 -> Fetch from Gerrit
Enter 98596 and press Ctrl+Space
-> This will fetch the changes in the Gerrit

Adjust the code and ammend and push the commit -> Updates the Gerrit

-------------------------------------
author: Brenden Conley
date: 2017-06-07 08:13:01.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12814/ : SUCCESS

-------------------------------------
