DESCRIPTION

WIP bug 517461 - [JFace] [snippets] Add JFace Snippet for TableViewer
with
DecoratingLabelProvider

Change-Id: I155bb48dce25a0600a20c1c34fdd427d07ace94b
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-06-07 11:23:30.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-06-07 11:23:35.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12824/

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 11:29:10.000000000

Patch Set 2:

Class name should be more descriptive, e.g., Snippet066TableViewWithDecoratingLabelProvider

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 11:38:50.000000000

Patch Set 2:

(6 comments)

Line:36, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> better private as it is only used in this example

Line:184, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> Unnecessary this.
Use better variable names, e.g. columnId

Line:201, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> columnFirstName

Line:223, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> columnLastName

Line:247, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> column.setResizable(true); would be nice

Line:251, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> Prefer List<Person>

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 11:40:34.000000000

Patch Set 2:

(1 comment)

Line:172, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> v.getTable().setHeaderVisible(true);

-------------------------------------
author: Brenden Conley
date: 2017-06-07 11:52:31.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12824/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 12:36:54.000000000

Patch Set 2:

(2 comments)

Line:90, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> Remove check, we know it is a Person, as you are setting the input.

Line:253, examples/org.eclipse.jface.snippets/Eclipse JFace Snippets/org/eclipse/jface/snippets/viewers/Snippet066DecoratingLabelProvider.java -> Better use vogella team members? This is more fun IMHO.

-------------------------------------
