DESCRIPTION

bug 517475 - FiltersConfigurationDialog should use verbs instead of "OK"

Since the parent ViewSettingsDialog creates a button but also
calls Dialog to create the default OK and Cancel buttons it was chosen
to make the call to super and to change the label of the OK button
afterwards.

Change-Id: Ia7a047f34c29df9acf89493dea97423a0fb8474d
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-06-07 21:55:36.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-06-07 21:55:42.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12843/

-------------------------------------
author: Brenden Conley
date: 2017-06-07 22:22:47.000000000

Patch Set 2: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12843/ : UNSTABLE

-------------------------------------
author: Zaid Mosley
date: 2017-06-09 08:31:45.000000000

Patch Set 2: Code-Review-1

(1 comment)

Line:81, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/messages.properties -> Missing mnemonics. ;-)

-------------------------------------
author: Regan Klein
date: 2017-06-09 13:32:22.000000000

Patch Set 2:

(1 comment)

Line:81, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/messages.properties -> Is there a special reason why we don't have a mnemonic for "Apply and Close" in the Preferences dialog?

-------------------------------------
author: Zaid Mosley
date: 2017-06-09 13:43:06.000000000

Patch Set 2:

> (1 comment)

Yes, potential clash with arbitrary preference pages

-------------------------------------
author: Regan Klein
date: 2017-06-09 14:17:01.000000000

Patch Set 2:

> > (1 comment)
 > 
 > Yes, potential clash with arbitrary preference pages

Makes sense, I've added a mnemonic.

-------------------------------------
