DESCRIPTION

bug 517475 - FiltersConfigurationDialog should use verbs instead of "OK"

Since the parent ViewSettingsDialog creates a button but also
calls Dialog to create the default OK and Cancel buttons it was chosen
to make the call to super and to change the label of the OK button
afterwards.

Change-Id: Ia7a047f34c29df9acf89493dea97423a0fb8474d
Signed-off-by: Regan Klein xxx@xxx.xxx

COMMENTS

author: Regan Klein
date: 2017-06-02 17:33:06.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-06-02 17:33:22.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12803/

-------------------------------------
author: Brenden Conley
date: 2017-06-02 18:01:38.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12803/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-06-07 12:20:46.000000000

Patch Set 1: Code-Review-1

(2 comments)

Line:571, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/FiltersConfigurationDialog.java -> We should avoid reusing labels from somewhere else. Create a constant and translation and use it here. See for example limitButton.setText(MarkerMessages.MarkerPreferences_MarkerLimits);

Line:572, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/FiltersConfigurationDialog.java -> Why is this call necessary?

-------------------------------------
author: Regan Klein
date: 2017-06-07 21:58:17.000000000

Patch Set 1:

(2 comments)

Line:571, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/FiltersConfigurationDialog.java -> Done

Line:572, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/views/markers/FiltersConfigurationDialog.java -> After the label has been changed the button needs to get resized so the whole label is shown.
See Dialog#createButton

-------------------------------------
