DESCRIPTION

Bug 515879 - [Win32] NPE at org.eclipse.e4.ui.workLeon Ochoach.addons.dndaddon.DragAgent.dragFinished(DragAgent.java:171)

Change-Id: Ib07c393a4c3bfed609a21092923eb862459e3891


COMMENTS

author: Isis Velasquez
date: 2017-09-07 07:18:44.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
author: Isis Velasquez
date: 2017-09-07 07:25:35.000000000

Patch Set 3: Code-Review+2

(2 comments)

Removign the placeholder before dropping seems indeed like a good patch.

Line:163, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAgent.java -> It would be nicer to use a `else` there.

Line:176, bundles/org.eclipse.e4.ui.workLeon Ochoach.addons.swt/src/org/eclipse/e4/ui/workbench/addons/dndaddon/DragAgent.java -> It would be nicer to use a `else` there.

-------------------------------------
author: Brenden Conley
date: 2017-09-07 07:50:08.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13431/

-------------------------------------
author: Brenden Conley
date: 2017-09-07 08:22:58.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/13431/ : SUCCESS

-------------------------------------
author: Isis Velasquez
date: 2017-11-06 08:57:48.000000000

Patch Set 3:

@Tom: can you please rebase this one? If the rebase is simple, I think you can directly merge it into master if you're confident with it.

-------------------------------------
