DESCRIPTION

Bug 516137 - Context menu in Ctrl+E is gone and right-click wrongly

Now "Delete" key closes the selected editor. Also the right-click on an
editor element opens a "Close" menu which allows to close the selected
editor.

Change-Id: I525d13d3ee7c8159d933afdcf4c6fb2ba190c08a
Signed-off-by: Ryker Bauer xxx@xxx.xxx
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Jayvion Booth
date: 2017-05-14 07:35:27.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-05-14 07:35:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12718/

-------------------------------------
author: Jayvion Booth
date: 2017-05-14 07:56:51.000000000

Patch Set 2: Code-Review+1

(6 comments)

The change does what it says, I've fixed some minor issues below.

Line:659, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> No need to keep experiments commented out

Line:675, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> Seem to be not needed

Line:780, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> This is not needed here

Line:648, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> Paranoia

Line:670, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> Please always use curly braces with if/else

Line:777, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/FilteredTableBaseHandler.java -> Avoids that non-functional "Delete" menu appears on "view" entries.

If we want support for closing views via "Delete", we should implement it in close(TableItem) and relax the condition here.

-------------------------------------
author: Brenden Conley
date: 2017-05-14 07:59:17.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12718/ : SUCCESS

-------------------------------------
