DESCRIPTION

Bug 516530 - Use StringBuilder instead of StringBuffer -
org.eclipse.ui.ide

Change-Id: I1d58dfa9007e70b31e6afa77ea31f5283f1717de 
Signed-off-by: Zaid Mosley xxx@xxx.xxx

COMMENTS

author: Zaid Mosley
date: 2017-06-20 09:52:02.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2017-06-20 09:52:08.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12977/

-------------------------------------
author: Zaid Mosley
date: 2017-06-20 10:09:17.000000000

Patch Set 3:

(1 comment)

Line:297, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/actions/OpenWorkspaceAction.java -> I was planning to add the information why 512 is used but this line was latest changed via commit 4c330e67056f9376502c63a5ba3e642e01d4d826 from 11 years ago in the cvs time line. Also the previous commit 5af4b1cbf3084246afc02755dc3ea5ff8edc3b40 does not contain any information

-------------------------------------
author: Zaid Mosley
date: 2017-06-20 10:18:39.000000000

Patch Set 3:

(4 comments)

Line:123, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/TarOutputStream.java -> Unfortunately, I cannot find useful information in the commit history why it uses this value. See commit 917ec00f66d4f27c1d3570ac858326f218c39b02 from 13 years ago.

Line:518, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/tasklist/TaskList.java -> This needs to be removed.

Line:114, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/BookmarkLabelProvider.java -> Also no useful information in the history see 5158b5b550e6de08239c60308efcf211a57f1bce 13 years ago.

Line:63, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/bookmarkexplorer/MarkerUtil.java -> same here

-------------------------------------
author: Brenden Conley
date: 2017-06-20 10:20:54.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12977/ : SUCCESS

-------------------------------------
