DESCRIPTION

Bug 516114: Add support for styling of TabbedProperties View

Adding CSS styling support for the tabbed properties in the properties
view. This includes styling of the TabbedPropertyTitle (title bar on
top) and styling of the TabbedPropertyList (the tabs on the left).

Change-Id: I6f92c73fb94e269e4a172dd0dde8ddda017dea31
Signed-off-by: Sheldon Collins xxx@xxx.xxx


COMMENTS

author: Sheldon Collins
date: 2017-05-15 07:05:58.000000000

Patch Set 13: Patch Set 12 was rebased

-------------------------------------
author: Brenden Conley
date: 2017-05-15 07:06:06.000000000

Patch Set 13:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12720/

-------------------------------------
author: Sheldon Collins
date: 2017-05-15 07:06:24.000000000

Patch Set 13: Code-Review+1

Do I still have to do something?

-------------------------------------
author: Brenden Conley
date: 2017-05-15 07:31:54.000000000

Patch Set 13: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12720/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-05-15 13:02:38.000000000

Patch Set 13:

Matthias, if I use the latest patch set, it looks like the following to me under Linux: http://imgur.com/a/PlJaK

-------------------------------------
author: Sheldon Collins
date: 2017-05-15 13:12:35.000000000

Patch Set 13:

last patch set (just fetched it again from gerrit) look like ok:
http://imgur.com/a/KuphT

Do you have all the changes projects in your workspace?

-------------------------------------
author: Sheldon Collins
date: 2017-05-15 13:14:37.000000000

Patch Set 13:

> last patch set (just fetched it again from gerrit) look like ok:
 > http://imgur.com/a/KuphT
 > 
 > Do you have all the changes projects in your workspace?

You can use the "import changes projects" in the commit's context menu in the history view for importing all projects that where changed by this commit.

-------------------------------------
author: Zaid Mosley
date: 2017-05-15 15:25:40.000000000

Patch Set 13:

> Do you have all the changes projects in your workspace?

Yes.

-------------------------------------
author: Zaid Mosley
date: 2017-05-15 16:37:30.000000000

Patch Set 13:

Also colorsAreStyled fails locally for me:

java.lang.AssertionError: expected:<RGB {255, 0, 0}> but was:<RGB {255, 255, 255}>

-------------------------------------
author: Zaid Mosley
date: 2017-05-15 17:11:28.000000000

Patch Set 13:

Ah, found it. I had a misbehaving other plug-in in the runtime. I continue to test.

-------------------------------------
