DESCRIPTION

Bug 516114: Add support for styling of TabbedProperties View

Adding CSS styling support for the tabbed properties in the properties
view. This includes styling of the TabbedPropertyTitle (title bar on
top) and styling of the TabbedPropertyList (the tabs on the left).

Change-Id: I6f92c73fb94e269e4a172dd0dde8ddda017dea31
Signed-off-by: Sheldon Collins xxx@xxx.xxx


COMMENTS

author: Sheldon Collins
date: 2017-05-12 07:57:30.000000000

Uploaded patch set 10.

-------------------------------------
author: Brenden Conley
date: 2017-05-12 07:57:35.000000000

Patch Set 10:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12711/

-------------------------------------
author: Sheldon Collins
date: 2017-05-12 07:57:48.000000000

Patch Set 10:

> Build Unstable
 > 
 > https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12710/
 > : UNSTABLE

Fixed with patch set 10

-------------------------------------
author: Brenden Conley
date: 2017-05-12 08:23:36.000000000

Patch Set 10: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12711/ : SUCCESS

-------------------------------------
author: Sheldon Collins
date: 2017-05-12 09:18:27.000000000

Patch Set 10:

Is patchset 10 now ok?  Or do you still have remarks?

-------------------------------------
author: Zaid Mosley
date: 2017-05-12 12:12:52.000000000

Patch Set 10: Code-Review-1

(2 comments)

Line:31, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/css/TabbedPropertyTitleCssPropertyHandler.java -> avoid static, the CSS engine should not initialize this more than once

Line:33, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/css/TabbedPropertyTitleCssPropertyHandler.java -> static initializers are evil, they force memory consumption even if class is never initialized. Please use the constructor.

-------------------------------------
