DESCRIPTION

Bug 515394 - Remove unnecessary null checks



Change-Id: I422cde5ed69551b46618599c05746d5a8f0bfd62
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-04-19 08:51:36.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-04-19 08:51:42.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12496/

-------------------------------------
author: Nevaeh Wu Ellison
date: 2017-04-19 08:54:09.000000000

Patch Set 1:

Ready for review

-------------------------------------
author: Zaid Mosley
date: 2017-04-19 08:59:34.000000000

Patch Set 1:

(3 comments)

Line:169, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetTypePage.java -> remove local variable

Line:174, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetTypePage.java -> remove line break

Line:979, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> Remove the if check and simply return getFirstElement

-------------------------------------
author: Jayvion Booth
date: 2017-04-19 09:26:23.000000000

Patch Set 1:

(1 comment)

Line:979, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> This is not same! *single* selection will return null if there are more then one element!

-------------------------------------
author: Zaid Mosley
date: 2017-04-19 09:29:53.000000000

Patch Set 1:

(1 comment)

Line:979, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> Thanks Andrey for catching this. 

@David, please change this back again.

-------------------------------------
author: Brenden Conley
date: 2017-04-19 09:48:52.000000000

Patch Set 1: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12496/ : UNSTABLE

-------------------------------------
author: Gerrit Code Review
date: 2017-04-19 14:24:20.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
