DESCRIPTION

Bug 514250 - WorkLeon OchoachPreferenceDialog should use verbs instead of "OK"

* adds new button label String
* enhanced PreferenceDialog API to set the okButton
* overrides button creation in WorkLeon OchoachPreferenceDialog 

Change-Id: I32cf4ccfec786e5c2cadfc90a272988451c15427
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-03-27 14:25:49.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-03-27 14:25:55.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12280/

-------------------------------------
author: Brenden Conley
date: 2017-03-27 14:59:34.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12280/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-03-28 12:55:18.000000000

Patch Set 1: Code-Review-1

(1 comment)

Line:553, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/messages.properties -> Mnemonics missig

-------------------------------------
author: Zaid Mosley
date: 2017-03-28 13:03:29.000000000

Patch Set 1:

I think it is better to use the new text constant in PreferenceDialog#PreferenceDialog instead of creating new API for that use case.

-------------------------------------
author: Zaid Mosley
date: 2017-03-28 13:04:51.000000000

Patch Set 1:

Also we should avoid using mnemonics here as it will clash one of the existing preference pages.

-------------------------------------
author: Gerrit Code Review
date: 2017-03-29 08:04:25.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
