DESCRIPTION

Bug 514058 - [API] Fix new MessageDialogWithToggle APIs

Change-Id: I18feee8eea643a821601105d7f231f5a4f876704
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2017-03-22 18:53:56.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12253/

-------------------------------------
author: Zaid Mosley
date: 2017-03-22 19:09:37.000000000

Patch Set 2:

(3 comments)

Line:132, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialogWithToggle.java -> I think you can completely remove the "Otherwise"... statement, this is explained in the corresponding method

Line:469, bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/MessageDialogWithToggle.java -> I think you can completely remove the "Otherwise"... statement, this is explained in the corresponding constructor

Line:19, bundles/org.eclipse.jface/.settings/.api_filters -> If I remove this I do not see any API baseline errors. I think you can remove it. Maybe you have to run Project -> Clean

-------------------------------------
author: Brenden Conley
date: 2017-03-22 19:24:26.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12253/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2017-03-27 11:14:10.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
