DESCRIPTION

Bug 484248 - [Common Navigator] CommonSorterDescriptor doesn't support
ViewerComparator

Allow to contribute ViewerComparator to navigatorContent/commonSorter
extension. The contribution will be automatically wrapped into a new
(non-API) WrappedViewerComparator instance before passing through to the
old API.

For now we only allow to contribute ViewerComparator instances via
plugin.xml, the old ViewerSorter based API is untouched by this change.

Change-Id: Ibcf6978cc9e562ef9cb1da6e3a878bff09bf2236
Signed-off-by: Jayvion Booth xxx@xxx.xxx


COMMENTS

author: Jayvion Booth
date: 2017-03-22 13:20:41.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2017-03-22 13:20:47.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12242/

-------------------------------------
author: Brenden Conley
date: 2017-03-22 13:47:43.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12242/ : SUCCESS

-------------------------------------
author: Alayna Houston
date: 2017-03-22 14:25:56.000000000

Patch Set 1:

(5 comments)

Yup, that's what I meant. Just a few minor comments.

Line:320, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/SorterTest.java -> COMPARATOR?

Line:102, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Spurious empty line, but then I don't know what the formatting conventions in UI are.

Line:109, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Why package-visible?

Line:124, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Public for testing only? Mention in javadoc?

Line:151, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> For testing only? I don't think there'd be other use cases. Maybe mention in the javadoc?

-------------------------------------
author: Jayvion Booth
date: 2017-03-22 14:52:51.000000000

Patch Set 1:

(5 comments)

Thanks Thomas for review!

Line:320, tests/org.eclipse.ui.tests.navigator/src/org/eclipse/ui/tests/navigator/SorterTest.java -> copy/paste :-)

Line:102, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Done

Line:109, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> to avoid synthetic method generation. I've used to do this, but here it is not relevant.

Line:124, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Done

Line:151, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptor.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2017-03-22 17:50:46.000000000

Change has been successfully merged into the git repository by Jayvion Booth

-------------------------------------
