DESCRIPTION

Bug 511846 - clear menu items prior to creating the control (and
potentially creating new menu items)

Change-Id: Id922dfa2529a15fb83926327e96cb6d6a2fff734
Signed-off-by: Konner Mcintyre xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2017-03-10 17:33:48.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12198/

-------------------------------------
author: Zaid Mosley
date: 2017-03-10 17:43:12.000000000

Patch Set 2: Code-Review+1 Verified+1

Fix looks fine and save to me. 

Brian, can you also have a look?

-------------------------------------
author: Brenden Conley
date: 2017-03-10 18:05:35.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12198/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-03-31 11:12:51.000000000

Patch Set 2: Code-Review+2

Brian, any concerns here? Otherwise, I plan to merge it next week.

-------------------------------------
author: Teagan Marsh
date: 2017-04-18 00:47:32.000000000

Patch Set 2:

Seems to make sense.  It would be nice to have a test for verification?  Maybe something like MenuPopulationTest#testMenuServicePopupContribution where it was using the problems view for testing?

-------------------------------------
author: Zaid Mosley
date: 2017-05-03 08:40:38.000000000

Patch Set 3: Patch Set 2 was rebased

-------------------------------------
