DESCRIPTION

Bug 506019 - [regression] editors list shown with Ctrl+E lost some of

Active editor is shown in bold, and background of the hidden editors is
shown in light gray.

Change-Id: I1cd23a3279af318b6a63a18f3589c9ab2775b239
Signed-off-by: Ryker Bauer xxx@xxx.xxx
Signed-off-by: Jayvion Booth xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2017-02-22 12:17:15.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12112/

-------------------------------------
author: Jayvion Booth
date: 2017-02-22 12:17:31.000000000

Patch Set 6:

Lars, any comments from your side?

-------------------------------------
author: Zaid Mosley
date: 2017-02-22 12:37:53.000000000

Patch Set 6:

> Lars, any comments from your side?

Currently working for a customer in Android Land, so unfortunately I do not have the time to review.

-------------------------------------
author: Brenden Conley
date: 2017-02-22 12:42:47.000000000

Patch Set 6: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12112/ : SUCCESS

-------------------------------------
author: Ryker Bauer
date: 2017-02-22 18:52:21.000000000

Patch Set 6:

I like the additions introduced with the last patch. There is still an issue with Windows. See details below 

> > Uploaded patch set 5.
 > 
 > Patrik, can you please check this on Windows?

It does not work, as in windows the retrieved color is white (#FF FF FF), 
see: http://i.imgur.com/b2Os7qh.png
 
 > Also I wonder why do we change only WorkbookEditorsHandler and not
 > the CycleEditorHandler? Is there are reason why they are
 > differently implemented?

The idea is to remove the CycleEditorHandler, as we have similar logic and code for: CycleEditor (Ctrl+E) , Switch Editor (Ctrl+F6), Switch View(Ctrl+F7) and Switch Perspective (Ctrl+F8)

-------------------------------------
author: Gerrit Code Review
date: 2017-02-22 22:21:22.000000000

Change has been successfully merged into the git repository by Ryker Bauer

-------------------------------------
