DESCRIPTION

Bug 511714 - Consistent usage of getStructuredSelection for Viewers in
eclipse.platform.ui

* replaces getSelection() with getStructuredSelection() for 

Change-Id: Ia57589cd85966ef25ec044f1322413bfd2274ae6
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Brenden Conley
date: 2017-04-18 08:42:10.000000000

Patch Set 9:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12487/

-------------------------------------
author: Brenden Conley
date: 2017-04-18 09:15:34.000000000

Patch Set 9: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12487/ : SUCCESS

-------------------------------------
author: Zaid Mosley
date: 2017-04-18 13:41:38.000000000

Patch Set 9: Code-Review+2

(4 comments)

Line:169, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetTypePage.java -> Also here selection cannot be null. Add this also to your new bug.

Line:979, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java -> selection cannot be null -> Add to new bug

Line:75, tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/viewers/ComboViewerComparerTest.java -> Create new bug to use IStructuredSelection instead of concrete type.

Line:302, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java -> selection cannot be null (see Javadoc), please create a new bug to remove this unnecessary null check.

-------------------------------------
author: Gerrit Code Review
date: 2017-04-18 13:42:02.000000000

Project policy requires all submissions to be a fast-forward.

Please rebase the change locally and upload again for review.

-------------------------------------
author: Zaid Mosley
date: 2017-04-18 13:42:07.000000000

Patch Set 10: Patch Set 9 was rebased

-------------------------------------
author: Gerrit Code Review
date: 2017-04-18 13:43:12.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
