DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part 11

Change-Id: I43a234cebe96d13e24c39ba1dc003dff16ff6852
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-14 16:06:03.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2017-02-14 16:06:09.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12055/

-------------------------------------
author: Nevaeh Wu Ellison
date: 2017-02-14 16:06:57.000000000

Patch Set 3:

Ready for review

-------------------------------------
author: Brenden Conley
date: 2017-02-14 16:12:38.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12055/ : FAILURE

-------------------------------------
author: Regan Klein
date: 2017-02-16 02:42:20.000000000

Patch Set 3:

(20 comments)

Line:191, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkLeon OchoachActivityHelper.java -> can fit in one line

Line:174, bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/model/WorkLeon OchoachContentProvider.java -> rename 'affectedChild'

Line:207, bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/model/WorkLeon OchoachContentProvider.java -> rename 'affectedChild'

Line:202, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/undo/ContainerDescription.java -> can fit on one line

Line:204, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/undo/ContainerDescription.java -> can fit on one line

Line:208, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/undo/ContainerDescription.java -> can fit on one line

Line:210, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/undo/ContainerDescription.java -> can fit on one line

Line:297, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkLeon OchoachPlugin.java -> inline

Line:49, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/model/WorkLeon OchoachProject.java -> comment got lost, please restore

Line:48, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/model/WorkLeon OchoachProject.java -> can fit in one line

Line:57, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/model/WorkLeon OchoachProject.java -> can fit in one line

Line:233, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/registry/MarkerHelpRegistry.java -> remove empty line

Line:244, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/registry/MarkerHelpRegistry.java -> can fit on one line

Line:96, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/AboutInfo.java -> inline

Line:99, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/AboutInfo.java -> fits in one line

Line:162, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ResourceWorkingSetUpdater.java -> can fit in one line

Line:132, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/ArchiveFileExportOperation.java -> rename 'child'

Line:71, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDESelectionConversionService.java -> rename 'currentResource' or 'traversalResource'

Line:138, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/filesystem/FileSystemSupportRegistry.java -> can fit in one line

Line:179, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceWithSettingsDialog.java -> the original code called this 'settingsTransfer', what was the reason to change it?

-------------------------------------
author: Nevaeh Wu Ellison
date: 2017-02-16 16:19:40.000000000

Patch Set 3:

Fixed feedback

-------------------------------------
author: Gerrit Code Review
date: 2017-02-17 08:22:47.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
