DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part9

Change-Id: I3acf2db702cbf71b421ef54c4860a1d4f1cbdbfc
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-14 14:08:01.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2017-02-14 14:08:07.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12052/

-------------------------------------
author: Nevaeh Wu Ellison
date: 2017-02-14 14:08:17.000000000

Patch Set 3:

Ready for review

-------------------------------------
author: Brenden Conley
date: 2017-02-14 14:14:43.000000000

Patch Set 3: Verified-1

Build Failed 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/12052/ : FAILURE

-------------------------------------
author: Regan Klein
date: 2017-02-16 00:43:42.000000000

Patch Set 3:

(18 comments)

Line:319, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/AbstractResourcesOperation.java -> can fit in one line

Line:324, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/AbstractResourcesOperation.java -> can fit in one line

Line:83, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/DeleteResourcesOperation.java -> can fit in one line

Line:83, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/AbstractCreateResourcesOperation.java -> can fit on one line

Line:334, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerGroup.java -> fits on one line

Line:585, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java -> rename 'type'

Line:588, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerSupportRegistry.java -> rename 'markerType'

Line:435, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/ResourceEncodingFieldEditor.java -> rename 'child'

Line:125, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/MainActionGroup.java -> remove empty line

Line:126, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/MainActionGroup.java -> rename 'projectDelta'?

Line:89, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/ContentGeneratorDescriptor.java -> 'grouping' seemed to be correct?

Line:215, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo/CopyResourcesOperation.java -> can fit in one line

Line:445, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/tasklist/TaskList.java -> hides variable from outer scope, rename 'child'

Line:1265, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/tasklist/TaskList.java -> fits in one line

Line:320, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerFilter.java -> this is confusing, either rename IResource to 'currentFocusResource' or rename the field to 'focusResources'. I would prefer the latter.

Line:331, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerFilter.java -> same

Line:337, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerFilter.java -> same

Line:451, bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/tasklist/TaskListContentProvider.java -> rename 'rootType'

-------------------------------------
author: Gerrit Code Review
date: 2017-02-17 07:24:20.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
