DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part4

Change-Id: I635b8d5bf4519e3fe84d006962db1eb8ecb1d891
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-07 15:02:23.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-02-07 15:39:41.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11989/

-------------------------------------
author: Brenden Conley
date: 2017-02-07 16:33:36.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11989/ : SUCCESS

-------------------------------------
author: Regan Klein
date: 2017-02-09 00:24:17.000000000

Patch Set 2:

(30 comments)

There can be made a case for inlining variable declarations like
Object[] array = getListeners();
instead of renaming the variable.
I'm not sure what the original intention was.

Line:116, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/WorkbenchPart.java -> rename 'listeners'

Line:117, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/WorkbenchPart.java -> rename 'listener'

Line:118, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/WorkbenchPart.java -> rename 'propertyListener'

Line:334, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/preferences/ScopedPreferenceStore.java -> rename 'listeners'

Line:340, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/preferences/ScopedPreferenceStore.java -> rename 'listener'

Line:341, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/preferences/ScopedPreferenceStore.java -> rename 'propertyListener'

Line:134, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyViewer.java -> rename 'child'

Line:172, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workLeon Ochoach/ResourceExtensionContentProvider.java -> rename 'affectedChild'

Line:208, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/workLeon Ochoach/ResourceExtensionContentProvider.java -> rename 'affectedChild'

Line:245, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/PageBookView.java -> rename 'selectionChangedListener'

Line:1104, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/PageBookView.java -> rename 'viewPart'

Line:601, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkLeon OchoachWindowAdvisor.java -> call values()

Line:601, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkLeon OchoachWindowAdvisor.java -> should be possible to use more specific type

Line:602, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkLeon OchoachWindowAdvisor.java -> remove

Line:603, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkLeon OchoachWindowAdvisor.java -> inline into for loop head?

Line:127, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/PasteAction.java -> rename 'resource'

Line:194, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/PasteAction.java -> rename 'resource'

Line:239, bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/PasteAction.java -> rename 'resource'

Line:111, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/PageBook.java -> remove

Line:170, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/AbstractMultiEditor.java -> rename 'child'

Line:388, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyList.java -> remove

Line:399, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyList.java -> remove

Line:114, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/IntroPart.java -> rename 'listeners'

Line:115, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/IntroPart.java -> rename 'listener'

Line:116, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/IntroPart.java -> rename 'propertyListener'

Line:236, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java -> remove

Line:298, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java -> rename 'desciptor'

Line:299, bundles/org.eclipse.ui.views.properties.tabbed/src/org/eclipse/ui/internal/views/properties/tabbed/view/TabbedPropertyRegistry.java -> rename 'filteredDescriptor'

Line:640, bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkLeon OchoachAdvisor.java -> rename 'previousFeature'

Line:129, bundles/org.eclipse.ui.workLeon Ochoach/Eclipse UI/org/eclipse/ui/part/MultiEditorInput.java -> rename 'editorInput'

-------------------------------------
author: Gerrit Code Review
date: 2017-02-14 14:33:04.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
