DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part3

Change-Id: I0604be64a9287a0b16ea5764d81c8410dd07dc37
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-07 14:53:29.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-02-07 14:56:07.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11988/

-------------------------------------
author: Brenden Conley
date: 2017-02-07 15:40:36.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11988/ : SUCCESS

-------------------------------------
author: Regan Klein
date: 2017-02-07 21:54:20.000000000

Patch Set 2:

(32 comments)

Line:194, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/CommonActionDescriptorManager.java -> indentation?

Line:336, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/CommonActionDescriptorManager.java -> indentation?

Line:484, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserPreferencePage.java -> unnecessary

Line:78, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CommonFilterDescriptorManager.java -> replace these 3 lines with:
for (CommonFilterDescriptor descriptor : filters.values()) {

Line:145, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/CommonSorterDescriptorManager.java -> fits on one line?

Line:330, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorActivationService.java -> can fit on one line

Line:368, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorActivationService.java -> can fit on one line

Line:328, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentService.java -> is this a gerrit problem or wrong indentation?

Line:1108, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentService.java -> fits on one line?

Line:1127, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentService.java -> indentation?

Line:59, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/sorters/NavigatorSorterService.java -> rename 'descriptor'

Line:83, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/OverridePolicy.java -> rename 'policy'?

Line:155, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/Priority.java -> rename 'priority'

Line:216, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CommonFiltersTab.java -> rename 'checkedItem'?

Line:227, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/filters/CommonFiltersTab.java -> rename 'child'?

Line:261, bundles/org.eclipse.ui.Diego Hamiltonr/src/org/eclipse/ui/internal/browser/WebBrowserUtil.java -> add brackets

Line:332, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceLabelProvider.java -> rename

Line:333, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceLabelProvider.java -> rename

Line:54, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/ContributorTrackingSet.java -> add brackets

Line:115, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/ContributorTrackingSet.java -> add brackets

Line:219, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonViewer.java -> rename 'changedElement'?

Line:202, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceContentProvider.java -> rename 'overridingExtension'

Line:206, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceContentProvider.java -> check if this is readable on one line

Line:208, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorContentServiceContentProvider.java -> check if this is readable on one line

Line:89, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/VisibilityAssistant.java -> rename 'extension'

Line:106, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorFilterService.java -> this shouldn't do anything?

Line:247, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorFilterService.java -> rename 'filterIdToActivate'

Line:446, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/NavigatorSaveablesService.java -> rename 'iDescriptor'?

Line:165, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/extensions/NavigatorViewerDescriptorManager.java -> rename 'property'

Line:101, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonDropAdapter.java -> fits on one line?

Line:125, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/navigator/CommonDropAdapter.java -> fits on one line?

Line:76, bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/dnd/CommonDropDescriptorManager.java -> indentation?

-------------------------------------
author: Zaid Mosley
date: 2017-02-09 16:05:09.000000000

Patch Set 2:

David, please give an indication, if you have fixed all feedback. Simply uploading a new change set is not a good indication if you are done with it.

-------------------------------------
author: Gerrit Code Review
date: 2017-02-10 09:02:55.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
