DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part2


Change-Id: I77afa243831ff3325c4d857c1b5b3531d98d6357
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-07 14:50:26.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2017-02-07 14:50:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11987/

-------------------------------------
author: Zaid Mosley
date: 2017-02-07 15:28:38.000000000

Patch Set 2:

(19 comments)

Line:331, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java -> Use better name here also

Line:333, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java -> Use a better name

Line:334, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/FinishedJobs.java -> Suggest to format this code block (ONLY THIS CODE BLOCK)

Line:509, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:542, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:588, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:604, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:617, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:636, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:653, bundles/org.eclipse.e4.ui.progress/src/org/eclipse/e4/ui/progress/internal/ProgressManager.java -> inline listeners.getListeners()

Line:86, bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/dialog/TitleAreaDialogSupport.java -> inline

Line:113, bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/dialog/TitleAreaDialogSupport.java -> inline

Line:477, bundles/org.eclipse.e4.ui.workLeon Ochoach.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/FilteredTree.java -> use treeItems instead of is

Line:160, bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java -> Property

Line:169, bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java -> Property

Line:134, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java -> use menuElement instead of ml

Line:85, bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/dialog/DialogPageSupport.java -> inline

Line:112, bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/dialog/DialogPageSupport.java -> inline

Line:466, bundles/org.eclipse.e4.ui.workLeon Ochoach.renderers.swt/src/org/eclipse/e4/ui/internal/workbench/renderers/swt/AbstractTableInformationControl.java -> Merge with line before

-------------------------------------
author: Brenden Conley
date: 2017-02-07 15:39:41.000000000

Patch Set 2: Verified+1

Build Successful 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11987/ : SUCCESS

-------------------------------------
author: Gerrit Code Review
date: 2017-02-10 08:57:27.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
