DESCRIPTION

Bug 511712 - Run cleanup action on eclipse.platform.ui/bundles to use
enhanced for loop - Part1

Change-Id: I60298d5492a0e5b49dfb72c5dfa60e686bcf1589
Signed-off-by: Nevaeh Wu Ellison xxx@xxx.xxx

COMMENTS

author: Nevaeh Wu Ellison
date: 2017-02-07 14:33:40.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2017-02-07 14:35:06.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11986/

-------------------------------------
author: Brenden Conley
date: 2017-02-07 15:15:42.000000000

Patch Set 3: Code-Review-1

Build Unstable 

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/11986/ : UNSTABLE

-------------------------------------
author: Regan Klein
date: 2017-02-07 16:39:10.000000000

Patch Set 3:

(27 comments)

Line:366, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/DataBindingContext.java -> rename 'binding'

Line:85, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/conversion/IdentityConverter.java -> rename 'primitivePair' or 'primitiveTuple'?

Line:148, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java -> does this fit on one line?

Line:85, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentitySet.java -> rename 'element'

Line:126, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentitySet.java -> rename 'element'

Line:81, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/BindingStatus.java -> does this fit on one line?

Line:86, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/Activator.java -> rename 'child'?

Line:63, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/validation/ObjectToPrimitiveValidator.java -> rename 'primitivePair' or 'primitiveTuple'?

Line:105, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> please add brackets

Line:111, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> rename 'element'

Line:113, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> please add brackets

Line:223, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> rename 'element'

Line:224, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> please add brackets

Line:321, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> rename 'element'

Line:323, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> add brackets

Line:362, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> rename 'element'

Line:379, bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/internal/databinding/identity/IdentityMap.java -> is this a gerrit bug or is the indentation actually wrong?

Line:63, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/set/UnionSetProperty.java -> add brackets

Line:568, bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java -> rename 'otherContext' or 'assignedContext'?

Line:608, bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java -> rename 'otherContext' or 'assignedContext'?

Line:75, bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/list/MultiListProperty.java -> add brackets

Line:105, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> rename 'observable'

Line:106, bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/ObservablesManager.java -> add brackets

Line:77, bundles/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ClassLookupSupport.java -> I like 'interfaze' more, since it's in line with the clazz naming 'convention'.

Line:160, bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java -> this should fit on one line

Line:161, bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java -> this does nothing

Line:163, bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java -> this does nothing

-------------------------------------
author: Regan Klein
date: 2017-02-07 16:41:11.000000000

Patch Set 3:

You can add curly brackets / block with a Quickfix action.

-------------------------------------
author: Regan Klein
date: 2017-02-07 21:58:56.000000000

Patch Set 3:

Please ignore my comments regarding brackets, I've created an issue for this: Bug 511868

-------------------------------------
author: Gerrit Code Review
date: 2017-02-10 08:57:06.000000000

Change has been successfully merged into the git repository by Zaid Mosley

-------------------------------------
